[Webkit-unassigned] [Bug 12073] Implement setCurrentTime() and pauseAnimations() on SVGSVGElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12073





--- Comment #23 from Joel Webber <jgw at chromium.org>  2011-11-22 05:11:38 PST ---
Eric, Nikolas:  Thanks for the prompt and detailed review.

I probably wasn't as clear on this as I should have been, but this patch wasn't intended to be committed quite yet. I was hoping to get feedback on the specific mechanisms called out in my first comment (SMILElement::reset() and the fact that inactive animations are no longer removed from SMILTimeContainer::m_scheduledAnimations).

If no one sees any serious problem with this approach, I'll continue cleaning it up in light of the review feedback. I'm also in the midst of writing more tests, as Nikolas suggests (thanks for the specific test suggestions), and I should have something ready later today. I've been testing them on Firefox, and will check Opera as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.