[Webkit-unassigned] [Bug 12073] Implement setCurrentTime() and pauseAnimations() on SVGSVGElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 22 00:45:26 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=12073


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116137|review?                     |review-
               Flag|                            |




--- Comment #22 from Nikolas Zimmermann <zimmermann at kde.org>  2011-11-22 00:45:25 PST ---
(From update of attachment 116137)
View in context: https://bugs.webkit.org/attachment.cgi?id=116137&action=review

I fully agree with Erics review comments. I have some more issues with testing:

> LayoutTests/svg/animations/script-tests/animate-setcurrenttime.js:31
> +animate1.setAttribute("to", "200");
> +animate1.setAttribute("fill", "freeze");

We need lots more tests, as you can guess :-)
* Accumulating animations need to be tested
* Several animations running in parallel
* Nested time containers, test modifying timeline in a inner <svg> element.
  <svg>some content <svg width="50" height="50"> rect-with-anim-in-inner-svg... </svg> </svg>
  Test moving time in outer <svg>, should it affect the inner <svg> timeline?
* Use pure SVG/HTML5 self-contained tests, not using script-tests/ framework as well
...
I'm sure I could come up with more, once I have some more time to think about that.
Do you also test your testcases in eg. Opera? Would be nice to have them pass in Opera fully as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list