[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #7 from jaehoon jeong <jh4u.jeong at samsung.com>  2011-11-21 00:48:27 PST ---
(From update of attachment 115750)
View in context: https://bugs.webkit.org/attachment.cgi?id=115750&action=review

>>> Source/CMakeLists.txt:52
>>> +SET(JS_ENGINE "JSC" CACHE STRING "choose which javascrit engine to use (one of ${ALL_JAVASCRIPT_ENGINES})")
>> 
>> typo: "javascrit"
> 
> I'd prefer the long name JAVASCRIPT_ENGINE

ok, I will change it to "JAVASCRIPT_ENGINE" :)

>> Source/CMakeLists.txt:56

> 
> If you set WTF_USE_V8, i think you should set WTF_USE_JSC too

I will define WTF_USE_JSC and set it too.

>> Source/CMakeLists.txt:146
>> +    ADD_SUBDIRECTORY(JavaScriptCore/wtf)
> 
> I think you should remove ADD_SUBDIRECTROY(wtf) from JavaScriptCore/CMakeLists.txt and always ADD_SUBDIRECTORY(JavaScriptCore/wtf) here

ok... Regardless of javascript engine, I make ADD_SUBDIRECTORY(JavaScriptCore/wtf) default and remove it from JavaScriptCore/CMakeLists.txt

>> Source/CMakeLists.txt:174
>> +IF (NOT WTF_USE_V8)
> 
> IF (WTF_USE_JSC) instead

ok.. I replace it with "WTF_USE_JSC"

>> Source/cmake/WebKitMacros.cmake:88
>> +        SET(_outputfiles "${_outputfiles}" ${DERIVED_SOURCES_WEBCORE_DIR}/${_namespace}ElementFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/${_namespace}ElementFactory.h ${DERIVED_SOURCES_WEBCORE_DIR}/${JAVASCRIPT_PREFIX}${_namespace}ElementWrapperFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/${JAVASCRIPT_PREFIX}${_namespace}ElementWrapperFactory.h)
> 
> What about the calls to GENERATE_DOM_NAMES in WebCore/CMakeLists.txt? This will result in an error, since e.g. JSHTMLElementWrapperFactory.cpp won't get generated. Maybe there are more problems of this kind.

hm.. I don't know exactly what you mean,,
so I will upload other patches for v8 in this bug... and then please review them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.