[Webkit-unassigned] [Bug 72692] [CMAKE] Add the configuration of cmake to select between JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72692





--- Comment #6 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-18 04:39:05 PST ---
(From update of attachment 115750)
View in context: https://bugs.webkit.org/attachment.cgi?id=115750&action=review

> ChangeLog:3
> +        [CMAKE] Add the configuration of cmake to select between JSC and V8.

not importent, but cmake is usually written as CMake

>> Source/CMakeLists.txt:52
>> +SET(JS_ENGINE "JSC" CACHE STRING "choose which javascrit engine to use (one of ${ALL_JAVASCRIPT_ENGINES})")
> 
> typo: "javascrit"

I'd prefer the long name JAVASCRIPT_ENGINE

> Source/CMakeLists.txt:56
> +    SET(WTF_USE_V8 1)

If you set WTF_USE_V8, i think you should set WTF_USE_JSC too

> Source/CMakeLists.txt:146
> +    ADD_SUBDIRECTORY(JavaScriptCore/wtf)

I think you should remove ADD_SUBDIRECTROY(wtf) from JavaScriptCore/CMakeLists.txt and always ADD_SUBDIRECTORY(JavaScriptCore/wtf) here

> Source/CMakeLists.txt:148
> +    ADD_SUBDIRECTORY(JavaScriptCore)

should be IF (WTF_USE_JSC) then

> Source/CMakeLists.txt:174
> +IF (NOT WTF_USE_V8)

IF (WTF_USE_JSC) instead

> Source/cmake/WebKitMacros.cmake:88
> +        SET(_outputfiles "${_outputfiles}" ${DERIVED_SOURCES_WEBCORE_DIR}/${_namespace}ElementFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/${_namespace}ElementFactory.h ${DERIVED_SOURCES_WEBCORE_DIR}/${JAVASCRIPT_PREFIX}${_namespace}ElementWrapperFactory.cpp ${DERIVED_SOURCES_WEBCORE_DIR}/${JAVASCRIPT_PREFIX}${_namespace}ElementWrapperFactory.h)

What about the calls to GENERATE_DOM_NAMES in WebCore/CMakeLists.txt? This will result in an error, since e.g. JSHTMLElementWrapperFactory.cpp won't get generated. Maybe there are more problems of this kind.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.