[Webkit-unassigned] [Bug 71372] Web Inspector: clear fixme in generator script
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 06:04:57 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=71372
--- Comment #8 from Peter Rybin <peter.rybin at gmail.com> 2011-11-17 06:04:56 PST ---
Ilya,
thank you for review.
> could you please also fix the indentation for InspectorBackendDispatcher.cpp
> the strings:
Done
> and extract String::format("Some arguments of method '%s' can't be processed", "blablabla")
> as an inline function.
I don't think this is really related. Let's handle it separately. By the way, I don't like its string formatting before the error actually happend anyway. On each message you allocate string buffer, build a string and never use it (until an actual error).
> > Source/WebCore/inspector/CodeGeneratorInspector.py:106
> unused. remove it.
Done
> > Source/WebCore/inspector/CodeGeneratorInspector.py:126
> capitalized. unused - remove it.
Done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list