[Webkit-unassigned] [Bug 71372] Web Inspector: clear fixme in generator script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 16 21:57:29 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71372





--- Comment #7 from Ilya Tikhonovsky <loislo at chromium.org>  2011-11-16 21:57:28 PST ---
(From update of attachment 115448)
View in context: https://bugs.webkit.org/attachment.cgi?id=115448&action=review

could you please also fix the indentation for InspectorBackendDispatcher.cpp
the strings:
if (!protocolErrors->length())
    m_anAgent->aCommand(blablabla)
sendResponse(callId, result, blablabla

        static CallHandler handlers[] = {
        &InspectorBackendDispatcher::Page_enable,

and extract String::format("Some arguments of method '%s' can't be processed", "blablabla")
as an inline function.

> Source/WebCore/inspector/CodeGeneratorInspector.py:106
> +    def lower_camel_case_to_upper(str):
> +        if len(str) > 0 and str[0].islower():
> +            str = str[0].upper() + str[1:]
> +        return str

unused. remove it.

> Source/WebCore/inspector/CodeGeneratorInspector.py:126
> +    def camel_case_to_capitilized_with_underscores(str):

capitalized. unused - remove it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list