[Webkit-unassigned] [Bug 72104] [GTK]Context menu doesn't display for selected node when menu is pressed.

Tue Nov 15 08:46:30 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72104

--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-11-15 08:46:30 PST ---
(In reply to comment #5)

> Actually this patch has two issues.
> 1. Placing the context menu below the focused node.
> Since we are using the y(), mouse event is created with top-left corner position. We take the event GlobalX,Y values to position the menu which is causing the menu to open at top-left corner. I used maxY() to display menu at bottom of node since firefox and chrome does same on menu key event.

It's probably best to move this particular change to another patch/bug, since it seems unrelated to the bug summary.

> 2. The location that we are calculating to create mouse event[x, maxY] is not giving the same selected/focused node in hitTestResult at given location point. This is causing the menu to create with different options. Hence I used margin to get the correct node(same node) in hitTest.

I think the use of gContextMenuMargin is inapparopriate here.  gContextMenuMargin is used to position the menu, not to find the element. Why not just find the centerpoint of the element and make the event there?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.