[Webkit-unassigned] [Bug 72104] [GTK]Context menu doesn't display for selected node when menu is pressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 06:02:41 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72104





--- Comment #5 from chandra shekar vallala <chandra.vallala at motorola.com>  2011-11-15 06:02:41 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> 
> > Its about displaying for wrong node.
> 
> I don't really get why you are using the context menu margin in the place that determines the location of the mouse click. Ideally figuring out where the mouse event is and positioning the popup menu are two different logical actions.  Are you sure the issue isn't that because we are using y() now the click is off the left edge of the node?  In that case, wouldn't it be better to put the context menu in the middle of the node?

Actually this patch has two issues.
1. Placing the context menu below the focused node.
Since we are using the y(), mouse event is created with top-left corner position. We take the event GlobalX,Y values to position the menu which is causing the menu to open at top-left corner. I used maxY() to display menu at bottom of node since firefox and chrome does same on menu key event.

2. The location that we are calculating to create mouse event[x, maxY] is not giving the same selected/focused node in hitTestResult at given location point. This is causing the menu to create with different options. Hence I used margin to get the correct node(same node) in hitTest.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list