[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #57 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2011-11-15 01:48:03 PST ---
(From update of attachment 114951)
View in context: https://bugs.webkit.org/attachment.cgi?id=114951&action=review

>> Source/WebCore/plugins/efl/PluginViewEfl.cpp:209

> 
> Unneeded empty line.

Same style applied in PluginViewGtk and PluginView.

>> Source/WebCore/plugins/efl/PluginViewEfl.cpp:278
>> +        *static_cast<void**>(value) = pluginScriptObject;
> 
> Is *static_cast correct usage ? I can't find similar usage in WebKit.

It's better to use static_cast in C++ than C-style cast. For similar usage see f.e. PluginViewMac: *static_cast<NPBool*>(value) = false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.