[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #56 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-11-14 20:16:46 PST ---
(From update of attachment 114951)
View in context: https://bugs.webkit.org/attachment.cgi?id=114951&action=review

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:209
> +

Unneeded empty line.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:214
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:219
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:224
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:240
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:244
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:262
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:278
> +        *static_cast<void**>(value) = pluginScriptObject;

Is *static_cast correct usage ? I can't find similar usage in WebKit.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:283
> +

ditto.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:292
> +

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.