[Webkit-unassigned] [Bug 72023] [GStreamer] GstCaps and GstPad RefPtr implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72023


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com




--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2011-11-11 07:20:02 PST ---
(In reply to comment #5)
> (From update of attachment 114493 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114493&action=review
> 
> Look like you are forgetting to use adoptGRef. Other than that this patch looks good. Thank you!
> 
> > Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:44
> > +        gst_object_ref(GST_OBJECT(ptr));
> 
> I think you should use gst_object_ref_sink here.
> 

Yes, giving it a try.

> > Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:57
> > +        gst_caps_ref(ptr);
> 
> And here as well.
> 

GstCaps is not a GstObject. It's a lightweight refcounted structure, gst_caps_ref is enough here I think.

> > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:95
> > +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()), "videoTee");
> 
> You need to call adoptGRef here if you don't want to leak the tee.
> 

Right!

> > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:107
> > +    GRefPtr<GstPad> srcPad = gst_element_get_request_pad(tee.get(), "src%d");
> > +    GRefPtr<GstPad> sinkPad = gst_element_get_static_pad(queue, "sink");
> 
> Ditto.
> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:163
> > +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()), "videoTee");
> 
> The same for all of these as well.

Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.