[Webkit-unassigned] [Bug 72023] [GStreamer] GstCaps and GstPad RefPtr implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72023


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114493|review?                     |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-11-10 09:13:12 PST ---
(From update of attachment 114493)
View in context: https://bugs.webkit.org/attachment.cgi?id=114493&action=review

Look like you are forgetting to use adoptGRef. Other than that this patch looks good. Thank you!

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:44
> +        gst_object_ref(GST_OBJECT(ptr));

I think you should use gst_object_ref_sink here.

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:57
> +        gst_caps_ref(ptr);

And here as well.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:95
> +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()), "videoTee");

You need to call adoptGRef here if you don't want to leak the tee.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:107
> +    GRefPtr<GstPad> srcPad = gst_element_get_request_pad(tee.get(), "src%d");
> +    GRefPtr<GstPad> sinkPad = gst_element_get_static_pad(queue, "sink");

Ditto.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:163
> +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()), "videoTee");

The same for all of these as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.