[Webkit-unassigned] [Bug 72031] [Qt] Skip tests when no network is present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 01:10:59 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72031


Bruno Abinader <bruno.de_oliveira at basyskom.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114520|0                           |1
        is obsolete|                            |
 Attachment #114644|                            |review?, commit-queue?
               Flag|                            |




--- Comment #9 from Bruno Abinader <bruno.de_oliveira at basyskom.de>  2011-11-11 01:10:59 PST ---
Created an attachment (id=114644)
 --> (https://bugs.webkit.org/attachment.cgi?id=114644&action=review)
Updated patch with memory allocation changes reviewed by Simon.

Good point Simon, I always tend to allocate objects on the heap while doing unit tests so I can delete them on a specific moment if needed. But in this case, as you said, it is not needed at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list