[Webkit-unassigned] [Bug 72031] [Qt] Skip tests when no network is present

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72031


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114520|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2011-11-10 13:56:31 PST ---
(From update of attachment 114520)
I think your patch looks good in general, but I also think that you can simplify it: Just allocate a QNetworkConfigurationManager instance directly as member variable. Then you don't need to allocate it on the heap and you don't need to deal with it in initTestCase().

QNetworkConfigurationManager itself is a pretty lightweight class that just forwards signals for the actual private singleton. There's no need to allocate it on the heap :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.