[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 4 11:58:27 PDT 2011


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #113692|review?                     |review+
               Flag|                            |

--- Comment #13 from Darin Adler <darin at apple.com>  2011-11-04 11:58:27 PST ---
(From update of attachment 113692)
View in context: https://bugs.webkit.org/attachment.cgi?id=113692&action=review

> Source/WebCore/html/HiddenInputType.h:38
> +class FormDataList;

This forward declaration is not needed. Not sure why you added it.

> Source/WebCore/html/HiddenInputType.h:55
> +    virtual bool appendFormData(FormDataList& encoding, bool isMultipartForm) const;

Here in the header, the argument name "encoding" is neither helpful nor desirable. Please omit it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list