[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19079


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113639|0                           |1
        is obsolete|                            |
 Attachment #113692|                            |review?, commit-queue?
               Flag|                            |




--- Comment #12 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2011-11-04 11:51:53 PST ---
Created an attachment (id=113692)
 --> (https://bugs.webkit.org/attachment.cgi?id=113692&action=review)
Updated patch as per review comments

Thanks Darin for review.

(In reply to comment #10)
> > Source/WebCore/html/InputType.cpp:178
> > +    if (equalIgnoringCase(element()->name(), "_charset_") && element()->isInputTypeHidden())
> 
> This is the wrong way to code something that’s type specific in InputType objects. Instead, HiddenInputType should override the appendFormData function.
> 
> The InputType objects were created to avoid having type-specific code mixed in with type-independent code, making use of isXXX checks like the one here.

Done.

> > Source/WebCore/html/InputType.cpp:179
> > +        encoding.appendData(element()->name(), String(encoding.encoding().name()));
> Why is an explicit String() needed here? Did you try compiling without it?

Yes I tried compiling it without String but it gives compile error as encoding().name() returns char*.

> HiddenInputType::appendFormData should check for the special case, and if it’s not the special case call through to InputType::appendFormData.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.