[Webkit-unassigned] [Bug 63616] Add missing methods used by fast/notifications tests to LayoutTestController
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 3 08:15:02 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=63616
Philippe Normand <pnormand at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #112682|review? |review-
Flag| |
--- Comment #14 from Philippe Normand <pnormand at igalia.com> 2011-11-03 08:15:02 PST ---
(From update of attachment 112682)
View in context: https://bugs.webkit.org/attachment.cgi?id=112682&action=review
Please correct me if I'm wrong but checkDesktopNotificationPermission() and areDesktopNotificationPermissionRequestsIgnored() are not needed at all.
> Tools/DumpRenderTree/LayoutTestController.h:143
> bool checkDesktopNotificationPermission(JSStringRef origin);
This doesn't seem to be used by any test. Might be worth just removing it all together from the LayoutTestController.
> Tools/DumpRenderTree/LayoutTestController.h:145
> + bool areDesktopNotificationPermissionRequestsIgnored();
This doesn't seem to be used by any LayoutTest. Why adding it?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list