[Webkit-unassigned] [Bug 63616] Add missing methods used by fast/notifications tests to LayoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 08:48:30 PDT 2011


--- Comment #15 from Alexandre Mazari <scaroo at gmail.com>  2011-11-03 08:48:30 PST ---
Philippe, Martin,

Thanks for the reviews!

The current form of this patch is obsolete. As suggested by martin, I wont remove the existing code dealing with the list of authorized origins.
The current approach was to delegate it to DumpRenderTreeSupportGtk in order to share that state between LTC and the gtk notifications api signals handlers.
It is a bit twisted and Philippe gave me the solution about the ENABLE macro within the Tools/DumpRenderTree/gtk tree.

So I am planning to:
- not remove the list of authorized origins and related methods from LTC
- add the list of pending requests in LTC with related methods
- use those from notifications-related callback in GTK's DumpRenderTree

After that remains the case of simulateDesktopNotificationClick (JString) used by

As its name suggests, it is used to simulate a click event on the native representation of the notification named after the passed string.
Obviously, LayoutTestController must have access to the list of notifications that is managed by DRT testing code. I have no idea on how to achieve that apart from delegating to DRTSupportGtk which is both accessible from LayouTestControllerGtk and gtk's DRT. I'd love to be proven wrong :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list