[Webkit-unassigned] [Bug 71436] DFG inlining breaks function.arguments[something] if the argument being retrieved was subjected to DFG's unboxing optimizations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71436





--- Comment #10 from Filip Pizlo <fpizlo at apple.com>  2011-11-03 00:09:33 PST ---
(In reply to comment #9)
> (From update of attachment 113438 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113438&action=review
> 
> r+, but i don't see any reason not to merge stackOffset and isCall
> 
> > Source/JavaScriptCore/bytecode/CodeOrigin.h:84
> >      unsigned stackOffset;
> > -    unsigned numArgumentsIncludingThis : 31;
> > -    bool isCall : 1;
> > +    bool isCall;
> 
> Can we merge stackOffset and isCall here?  I can't see us needing a 1gig stack offset...

Fair point.  I missed that somehow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.