[Webkit-unassigned] [Bug 71436] DFG inlining breaks function.arguments[something] if the argument being retrieved was subjected to DFG's unboxing optimizations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 00:07:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=71436


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113438|review?                     |review+
               Flag|                            |




--- Comment #9 from Oliver Hunt <oliver at apple.com>  2011-11-03 00:07:47 PST ---
(From update of attachment 113438)
View in context: https://bugs.webkit.org/attachment.cgi?id=113438&action=review

r+, but i don't see any reason not to merge stackOffset and isCall

> Source/JavaScriptCore/bytecode/CodeOrigin.h:84
>      unsigned stackOffset;
> -    unsigned numArgumentsIncludingThis : 31;
> -    bool isCall : 1;
> +    bool isCall;

Can we merge stackOffset and isCall here?  I can't see us needing a 1gig stack offset...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list