[Webkit-unassigned] [Bug 71427] Inlined uses of the global object should use the right global object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71427





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2011-11-02 19:31:01 PST ---
(In reply to comment #2)
> (From update of attachment 113413 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113413&action=review
> 
> r=me, but i don't believe that fix me is correct.
> 
> > Source/JavaScriptCore/dfg/DFGJITCompiler.h:439
> > +        // FIXME: if we ever inline based on executable not function, this code will need to change.
> 
> I don't believe that this is correct -- all functions for a given executable must by definition share the same global object.

If we inline based on executable, the inlineCallFrame->callee field will be 0, and there will be another field that tells you how to get the callee from the register file.  That's what I meant by the FIXME.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.