[Webkit-unassigned] [Bug 71427] Inlined uses of the global object should use the right global object

Wed Nov 2 19:30:06 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=71427

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113413|review?                     |review+
               Flag|                            |

--- Comment #2 from Oliver Hunt <oliver at apple.com>  2011-11-02 19:30:06 PST ---
(From update of attachment 113413)
View in context: https://bugs.webkit.org/attachment.cgi?id=113413&action=review

r=me, but i don't believe that fix me is correct.

> Source/JavaScriptCore/dfg/DFGJITCompiler.h:439
> +        // FIXME: if we ever inline based on executable not function, this code will need to change.

I don't believe that this is correct -- all functions for a given executable must by definition share the same global object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.