[Webkit-unassigned] [Bug 71225] [chromium] when position:fixed in a separate layer it doesn't get full resolution with css transform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71225





--- Comment #7 from James Robinson <jamesr at chromium.org>  2011-11-02 14:15:54 PST ---
(From update of attachment 113374)
View in context: https://bugs.webkit.org/attachment.cgi?id=113374&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:-468
> -

please don't make spurious changes to files like this. i think your editor is probably doing this, fix it

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:197
> +    float contentsScale() const { return m_contentsScale; }
> +    void setContentsScale(float contentsScale) { m_contentsScale = contentsScale; }

we already support the ability for layer bounds != content bounds via contentBounds()/bounds(). is it necessary to introduce another mechanism?

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:154
> +    canvasPainter.context()->scale(FloatSize(contentsScale, contentsScale));

if you're scaling the canvas you need to adjust the size of the allocated canvas as well, right? where is that being done?

> Source/WebKit/chromium/src/PageOverlay.cpp:81
> +    virtual float deviceScaleFactor() const
> +    {
> +        return 1;
> +    }
> +
> +    virtual float pageScaleFactor() const
> +    {
> +        return m_webViewImpl->pageScaleFactor();
> +    }

i don't understand this change at all. are you using PageOverlay?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.