[Webkit-unassigned] [Bug 71225] [chromium] when position:fixed in a separate layer it doesn't get full resolution with css transform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 14:26:08 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=71225





--- Comment #8 from Hin-Chung Lam <hclam at google.com>  2011-11-02 14:26:08 PST ---
(From update of attachment 113374)
View in context: https://bugs.webkit.org/attachment.cgi?id=113374&action=review

>> Source/WebCore/platform/graphics/chromium/LayerChromium.h:197
>> +    void setContentsScale(float contentsScale) { m_contentsScale = contentsScale; }
> 
> we already support the ability for layer bounds != content bounds via contentBounds()/bounds(). is it necessary to introduce another mechanism?

This is used in the painter of texture updater to apply scale to the canvas.

>> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:154
>> +    canvasPainter.context()->scale(FloatSize(contentsScale, contentsScale));
> 
> if you're scaling the canvas you need to adjust the size of the allocated canvas as well, right? where is that being done?

I thought setting the bounds of LayerChromium will changes the size of canvas, I'll check again.

> Source/WebCore/rendering/RenderLayer.cpp:3846
> +    bool paintsForFixedPositionLayer = renderer()->isPositioned() && renderer()->style()->position() == FixedPosition;

Don't mind changes in this file, it shouldn't be here..

>> Source/WebKit/chromium/src/PageOverlay.cpp:81
>> +    }
> 
> i don't understand this change at all. are you using PageOverlay?

deviceScaleFactor and pageScaleFactor are methods in GraphicsLayerClient. This change http://trac.webkit.org/changeset/91137 queries client for these scale factors, where is a better spot for implementing these two methods?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list