[Webkit-unassigned] [Bug 39284] Incorrect position of the vertical scrollbar after temporarily setting overflow:hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39284





--- Comment #19 from Robin Qiu <robin.qiu at torchmobile.com.cn>  2011-05-31 19:48:37 PST ---
(In reply to comment #18)
> Hi Robin
> 
> (In reply to comment #16)
> > Created an attachment (id=95417)
 --> (https://bugs.webkit.org/attachment.cgi?id=95417&action=review) [details] [details]
> > Patch
> > 
> > This is a simple patch. Only adds 2 lines code.
> 
> Just a few observations (I don't know about Scrollbar, so no official review).
> 
> The ChangeLogs usually have a different format, for example:
> 
>         [Texmap][Qt] Enable TextureMapper by default
>         https://bugs.webkit.org/show_bug.cgi?id=61740
> 
>         Make CONFIG+=texmap an opt-out instead of an opt-in.
> 
> I didn't find in the style guide that it must be like that, but why not stick to it?
> 
OK. I'll modify the changelog. 
The patch is platform independent, so, I guess it's not necessary to add a tag like [Qt]? 

> What about calling offsetDidChange instead? It also adjusts the thumb.

offsetDidChange() also updates the thumb and do some painting, but here, we only need to initialize current position.

> Cheers,
> 
> Rob.

Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.