[Webkit-unassigned] [Bug 39284] Incorrect position of the vertical scrollbar after temporarily setting overflow:hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39284


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwlbuis at gmail.com




--- Comment #18 from Rob Buis <rwlbuis at gmail.com>  2011-05-31 10:20:50 PST ---
Hi Robin

(In reply to comment #16)
> Created an attachment (id=95417)
 --> (https://bugs.webkit.org/attachment.cgi?id=95417&action=review) [details]
> Patch
> 
> This is a simple patch. Only adds 2 lines code.

Just a few observations (I don't know about Scrollbar, so no official review).

The ChangeLogs usually have a different format, for example:

        [Texmap][Qt] Enable TextureMapper by default
        https://bugs.webkit.org/show_bug.cgi?id=61740

        Make CONFIG+=texmap an opt-out instead of an opt-in.

I didn't find in the style guide that it must be like that, but why not stick to it?

What about calling offsetDidChange instead? It also adjusts the thumb.
Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.