[Webkit-unassigned] [Bug 60964] Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60964





--- Comment #10 from Ojan Vafai <ojan at chromium.org>  2011-05-31 13:22:18 PST ---
(From update of attachment 95465)
View in context: https://bugs.webkit.org/attachment.cgi?id=95465&action=review

Mihai, you're comment makes me think this should be R-'ed, no?

> Tools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:261
> +    if (selectedTypeIsSortable) {
> +        enableSorting();
> +    } else {
> +        disableSorting();
> +    }

Nit: WebKit style is to not use curly braces with single-line if/else statements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.