[Webkit-unassigned] [Bug 60964] Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 31 12:55:24 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60964





--- Comment #9 from Mihai Parparita <mihaip at chromium.org>  2011-05-31 12:55:24 PST ---
(In reply to comment #7)
> The intent was to have a bit of UI memory; if we change from looking at IMAGE to TEXT failure cases, and then back, we restore the sortedness/unsortedness from before.

Right, but if you only do the sorting (currently at lines 264 to 268) inside the selectedTypeIsSortableBranch (line 258), then I don't think you need to touch shouldSortTestsByMetric in enable/DisableSorting, hence you don't need wasSortingTestsByMetric.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list