[Webkit-unassigned] [Bug 60536] [GTK] Remove some unneeded header includes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60536





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-30 01:12:49 PST ---
(In reply to comment #2)
> (From update of attachment 92926 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92926&action=review
> 
> Typically
> 
> > Source/WebCore/bindings/js/ScriptControllerGtk.cpp:37
> > -#include "PluginView.h"
> >  #include "runtime_root.h"
> > +#include <WebCore/plugins/PluginView.h>
> >  
> 
> Since this includes a header inside WebCore it doesn't seem right to use a system include here. Is this change necessary?

Yes, because I'm building the plugin process with some of the webcore sources, so webcore and webkit2 cppflags are mixed. Maybe, we should create two libwebcoregtk, libwebcoregtk3 for webkit1 and webkit2 when building with gtk3 and libwecoregtk2 for webkit1 and webkit2 when building with gtk2 and for the plugin process unconditionally.

> > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:30
> >  #include "config.h"
> > -#include "PluginView.h"
> > +#include <WebCore/plugins/PluginView.h>
> 
> It's definitely not usual to do that here.

Yes, same issue, I don't like it either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.