[Webkit-unassigned] [Bug 60536] [GTK] Remove some unneeded header includes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 08:31:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60536


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92926|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-05-10 08:31:47 PST ---
(From update of attachment 92926)
View in context: https://bugs.webkit.org/attachment.cgi?id=92926&action=review

Typically

> Source/WebCore/bindings/js/ScriptControllerGtk.cpp:37
> -#include "PluginView.h"
>  #include "runtime_root.h"
> +#include <WebCore/plugins/PluginView.h>
>  

Since this includes a header inside WebCore it doesn't seem right to use a system include here. Is this change necessary?

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:30
>  #include "config.h"
> -#include "PluginView.h"
> +#include <WebCore/plugins/PluginView.h>

It's definitely not usual to do that here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list