[Webkit-unassigned] [Bug 61468] Web Inspector: Timeline panel improvements for managing current selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61468





--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2011-05-28 11:34:26 PST ---
> Strange because datagrid.js that I previously changed had variables with the same meaning done this way. To me it would make more sense to define it in prototype if its meaning is for object's internal use only(to save typing and lookup cost) and to use normal constants when it has some meaning for other objects. 
> 
> For example in timelineoverview, the resizer is private so why should any other object care about ResizerOffset constant.
> 

We would normally do either 
- WebInspector.TimelineOverviewPane._ResizerOffset or 
- this._resizerOffset initialized in the constructor for private values.

I don't think lookup cost is significant in the first case, but I agree that typing is a bit painful. I do realize the benefits of your approach, but I think that consistency (where prototypes only have methods) is at least as important. I think DataGrid is more of an exception / oversight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.