[Webkit-unassigned] [Bug 61468] Web Inspector: Timeline panel improvements for managing current selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61468





--- Comment #6 from tonistiigi at gmail.com  2011-05-28 10:49:07 PST ---
(In reply to comment #5)

> > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:372
> > +    ResizerOffset: 3.5, // half pixel because offset values are not rounded but ceiled
> 
> We don't define constants on prototypes, typically they are just WebInspector.TimelineOverviewPane.ResizerOffset.
> 

Strange because datagrid.js that I previously changed had variables with the same meaning done this way. To me it would make more sense to define it in prototype if its meaning is for object's internal use only(to save typing and lookup cost) and to use normal constants when it has some meaning for other objects. 

For example in timelineoverview, the resizer is private so why should any other object care about ResizerOffset constant.

> > Source/WebCore/inspector/front-end/inspector.css:2965
> > +    -webkit-transition: top 0.3s ease-out 0.2s;
> 
> Is this one smoothing labels flickering?  When I implemented it originally, labels were not flickering at all (see Safari 5 and earlier Chrome builds). It just regressed at some point. I'd rather find out why.

It doesn't indeed happen in Safari5(but happens on Chrome stable). I'll look more into it later because it is definitely better this way than the workaround with transition. I though it isn't possible to keep it from moving without position:fixed but I guess I was wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.