[Webkit-unassigned] [Bug 61680] editing/inserting/insert-3907422 should be dumpAsText test

Fri May 27 18:40:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61680

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95242|review?                     |review-
               Flag|                            |

--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-27 18:40:09 PST ---
(From update of attachment 95242)
View in context: https://bugs.webkit.org/attachment.cgi?id=95242&action=review

> LayoutTests/editing/inserting/insert-3907422-fix.html:21
> +    var result = root.children[0].nodeName == "BLOCKQUOTE" ? "FAIL" : "PASS";
> +    document.write(result + ": Buggy code before fix would insert blockquote after body element in second paste");

I don't think this is the correct check.  The bug was that the node was inserted AFTER body, not inside body.  In general, it's not a good idea to have a speculative PASS/FAIL like this unless you reverted the fix and confirmed that the test prints FAIL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.