[Webkit-unassigned] [Bug 61680] editing/inserting/insert-3907422 should be dumpAsText test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 18:38:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61680





--- Comment #6 from Annie Sullivan <sullivan at chromium.org>  2011-05-27 18:38:25 PST ---
(In reply to comment #3)
> (From update of attachment 95239 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95239&action=review
> 
> > LayoutTests/editing/inserting/insert-3907422-fix.html:20
> > -<body contenteditable id="test" class="editing">
> > +<body contenteditable id="root" class="editing" onload="runDumpAsTextEditingTest();">
> 
> I don't think we should change #test to #root either.  They are treated differently in editing.js

Whoops, didn't see this comment before. I didn't know "test" was a special id for editing.js. But of course "root" is too, and if I don't have a node with ID root, then I don't get output. I'm not sure how to refactor the test if we don't change body to id root--the point of the test is to do a select all, then copy/paste. If I added a containing root div, then the test would behave differently. If I put ids on divs that end up getting copy/pasted, the behavior of the test gets even harder to understand.

Maybe it would be better just not to use editing.js for this test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list