[Webkit-unassigned] [Bug 54417] [chromium] Add a basic gesture recognizer to the Chromium platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 09:16:01 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=54417





--- Comment #21 from Robert Kroeger <rjkroege at chromium.org>  2011-05-27 09:16:00 PST ---
(From update of attachment 94995)
View in context: https://bugs.webkit.org/attachment.cgi?id=94995&action=review

>> LayoutTests/fast/events/touch/touch-gesture-click.html:17
>> +div.style.backgroundColor = "blue";
> 
> This is a bit weird.
> I would have this target div in the html, and use document.getElementById() to get the element in runTest().
> 
> Currently, the span of code between the definition of div and its use is big, which does not help reading this code.

done in p6

>> LayoutTests/fast/events/touch/touch-gesture-click.html:47
>> +    // debug('have received: ' + event.type);
> 
> This can probably be removed :)

done in p6.

>> LayoutTests/fast/events/touch/touch-gesture-click.html:69
>> +
> 
> Empty line

done in p6

>> LayoutTests/fast/events/touch/touch-gesture-click.html:71
>> +        // debug('Received: ' + touchEventsReceived + ' mouse events ');
> 
> This can be removed.

done in p6

>> LayoutTests/fast/events/touch/touch-gesture-scroll.html:67
>> +var EXPECTED_SCROLLS_TOTAL = 2;
> 
> Uppercase with underscore, a bit uncommon.

I was following along with some of the other tests in the directory. changed in p6

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:55
>> +    , m_eventHandler(0)
> 
> To avoid duplicating this kind of code, you could not initialize anything and just call resetState().
> I don't mind the current code, just do as you prefer for this.

left as is.

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:129
>> +        // The graph is sparse: not all edges have functions.
> 
> The place of this comment is a bit weird.
> I don't think the comment is necessary.

removed in p6

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:140
>> +    PlatformWheelEvent syntheticWheelEvent(touchPoint.pos(), touchPoint.screenPos(), deltaX, deltaY, deltaX / static_cast<float>(120), deltaY / static_cast<float>(120), ScrollByPixelWheelEvent, false, false, false, false, false);
> 
> Same remark conerning the event key modifiers.

fixed in p6

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list