[Webkit-unassigned] [Bug 54417] [chromium] Add a basic gesture recognizer to the Chromium platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54417





--- Comment #20 from Robert Kroeger <rjkroege at chromium.org>  2011-05-27 08:30:55 PST ---
(From update of attachment 94995)
View in context: https://bugs.webkit.org/attachment.cgi?id=94995&action=review

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:93
>> +    PlatformMouseEvent fakeMouseUp(point.pos(), point.screenPos(), LeftButton, MouseEventReleased, /* clickCount */ 1, /* shift */ false, /* ctrl */ false, /* alt */ false, /* meta */ false, m_lastTouchTime);
> 
> You actually don't have to use false for all the modifiers. The PlatformTouchEvent has the value of shift, ctrl, alt, etc.

True. Done in p6.

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:152
>> +        m_lastTouchTime = touchTime;
> 
> You could set this above the if() since it is updated in both cases... just to make things simpler :)

done, p6

>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:163
>> +    return 1 + ((touchType & 0x7) | (handled ? 1 << 3 : 0) | ((id & 0xfff) << 4 ) | (gestureState << 16));
> 
> The +1 is suspicious as discussed on IRC :)

done in p6. Great catch. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.