[Webkit-unassigned] [Bug 61603] FEConcolveMatrix::getPixelValue() is range checking x against height, instead of y, when determining if a pixel is in bounds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61603





--- Comment #10 from Nikolas Zimmermann <zimmermann at kde.org>  2011-05-27 02:21:32 PST ---
(In reply to comment #8)
> I've attached a simple test that generates visibly different results with and without the fix.
> 
> Note, this is *NOT* a crash. This is because pixelIndex, returned as a negative value, is *not* used in fastSetOuterPixels. Instead, fastSetOuterPixels performs no illegal accesses due to pixelIndex being negative - it is properly checked at all times. However, because of the negative value, the totals are all 0, instead of their expected values, which is the result of the pixel from the row beneath. This is why I uploaded a pixel test.

Ok, great, please include a pixel test and the render tree dump generated with a vanilla mac. They have to be present in the patch, all other results can be generated - if needed - by using "webkit-patch rebaseline" after the patch has landed, if it generates different results on other platforms.


(In reply to comment #9)
> Since the ChangeLog will be crucial to getting this accepted, can you please point out what I might be doing wrong? I've been using webkit-patch and prepare-ChangeLog this entire time, and it seems it will not generate the change logs in the format you've requested?
> 
> Is there some other tool or guidance about how a change log should be formatted, if I needed to do it by hand?
It's really weird. I have never had trouble with it, maybe Eric Seidel or Adam Barth can help with your specific tool problem?

What happens if you invoke prepare-ChangeLog right in Source/WebCore?
I guess this is not a vanilla WebKit checkout, but a Chromium/Mac environment you're working in, I'm not familiar with that though. Maybe chromium folks on IRC can help you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.