[Webkit-unassigned] [Bug 61603] FEConcolveMatrix::getPixelValue() is range checking x against height, instead of y, when determining if a pixel is in bounds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 02:16:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61603





--- Comment #9 from Ryan Sleevi <rsleevi at chromium.org>  2011-05-27 02:16:44 PST ---
Since the ChangeLog will be crucial to getting this accepted, can you please point out what I might be doing wrong? I've been using webkit-patch and prepare-ChangeLog this entire time, and it seems it will not generate the change logs in the format you've requested

Ryan-Sleevis-Mac-mini:WebKit Ryan$ ./Tools/Scripts/prepare-ChangeLog --bug=61603
  Running status to find changed, added, or removed files.
?       Source/WebKit/chromium/WebKit.xcodeproj
?       Source/WebCore/WebCore.gyp/idls_list_temp_file.tmp
?       Source/ThirdParty/glu/glu.xcodeproj
?       LayoutTests/platform/chromium-mac/svg/filters/feConvolveFilter-bounds-expected.txt
?       LayoutTests/platform/chromium-mac/svg/filters/feConvolveFilter-bounds-expected.png
  Reviewing diff to determine which lines changed.
svn: '../../Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp' is not a working copy
svn: '../../Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp' does not exist
  Change author: Ryan Sleevi <rsleevi at chromium.org>.
  Description from bug 61603:
    "FEConcolveMatrix::getPixelValue() is range checking x against height, instead of y, when determining if a pixel is in bounds".
  Running 'svn update' to update ChangeLog files.
    At revision 87486.
  Editing the ./ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry. --
-- See <http://webkit.org/coding/contributing.html> for more info --

I've also tried with Tools/Scripts/ in my $PATH. I get the exact same results. I've also tried explicitly specifying the SVN directory via a relative path (prepare-ChangeLog can't handle absolute paths) to the same result.

Is there some other tool or guidance about how a change log should be formatted, if I needed to do it by hand?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list