[Webkit-unassigned] [Bug 60563] [Chromium]Click event is not fired for a menulist <select>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60563





--- Comment #40 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-05-26 09:16:35 PST ---
(From update of attachment 94898)
View in context: https://bugs.webkit.org/attachment.cgi?id=94898&action=review

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:193
> +    void acceptIndex(int index, const PlatformMouseEvent* event = 0);

this should just be const PlatformMouseEvent&.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:283
> +    Node* m_focusedNode;

This node could be removed from the tree while the popup is still open. I think you need a RefPtr here.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1104
> +            m_focusedNode->dispatchMouseEvent(*event, eventNames().mouseupEvent);

What's the re-entrance opportunity here? If up event removes the corresponding select element, are we still safe to continue this execution?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.