[Webkit-unassigned] [Bug 60563] [Chromium]Click event is not fired for a menulist <select>

Thu May 26 09:15:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60563

Jay Civelli <jcivelli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94898|review?                     |review-
               Flag|                            |

--- Comment #39 from Jay Civelli <jcivelli at chromium.org>  2011-05-26 09:15:39 PST ---
(From update of attachment 94898)
View in context: https://bugs.webkit.org/attachment.cgi?id=94898&action=review

> Source/WebCore/manual-tests/select-element-mouse-event.html:1
> + <!DOCTYPE html>

I wonder if it would be possible to add a test case for this in Source/WebKit/chromium/tests/PopupMenuTest.cpp?
The test framework let's you load HTML in a page, you could then explicitly open the popup and send a fake mouse event to it and ensure everything works as expected.
(and you could test with and without a focused node).

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:414
> +    listBox()->m_focusedNode = m_frameView->frame()->document()->focusedNode();

It would be a good idea to set m_focusedNode to 0 when we hide the popup, so we don't keep a pointer to a potentially deleted object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.