[Webkit-unassigned] [Bug 51247] css attribute + child selector not updated properly when attribute change

Wed May 25 09:52:45 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=51247

arno. <arno at renevier.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82602|0                           |1
        is obsolete|                            |
  Attachment #94798|                            |review?
               Flag|                            |

--- Comment #11 from arno. <arno at renevier.net>  2011-05-25 09:52:44 PST ---
Created an attachment (id=94798)
 --> (https://bugs.webkit.org/attachment.cgi?id=94798&action=review)
patch v1.5

(In reply to comment #10)
> 
> > LayoutTests/fast/css/attribute-child-selector-expected.txt:5
> > +The following line should say SUCCESS in green letters over a white background.
> > +
> > +SUCCESS
> 
> Why do we need to display this in a dumpAsText test?

I'm not sure I understand what you mean. What is a dumpAsText test ?
In this patch, I've removed "The following line should say SUCCESS in green letters over a white background." paragraph from the test.

> > LayoutTests/fast/css/attribute-child-selector.html:2
> > +<head id="head">
> 
> Why?

fixed

> > LayoutTests/fast/css/attribute-child-selector.html:20
> > +    <div id="console"> </div>
> 
> I suspect the space in this console is why there is a space before the PASS.

Yes, that is the reason, it's fixed in this patch.

> > LayoutTests/fast/css/attribute-child-selector.html:28
> > +        test();
> 
> No need to have a test function since you just call it directly.

thanks, that is also fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.