[Webkit-unassigned] [Bug 51247] css attribute + child selector not updated properly when attribute change

Mon May 23 14:05:31 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=51247

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82602|review?                     |review-
               Flag|                            |

--- Comment #10 from Eric Seidel <eric at webkit.org>  2011-05-23 14:05:30 PST ---
(From update of attachment 82602)
View in context: https://bugs.webkit.org/attachment.cgi?id=82602&action=review

This seems like a pretty simple patch.  We should be able to get hyatt to venture an opinion.  I think we should clean up the test a little and then we can press hyatt for review.

> LayoutTests/fast/css/attribute-child-selector-expected.txt:5
> +The following line should say SUCCESS in green letters over a white background.
> +
> +SUCCESS

Why do we need to display this in a dumpAsText test?

> LayoutTests/fast/css/attribute-child-selector-expected.txt:7
> + PASS getComputedStyle(document.getElementById('bar')).getPropertyValue('color') is 'rgb(0, 128, 0)'

Why is there a leading space before the PASS?

> LayoutTests/fast/css/attribute-child-selector.html:2
> +<head id="head">

Why?

> LayoutTests/fast/css/attribute-child-selector.html:20
> +    <div id="console"> </div>

I suspect the space in this console is why there is a space before the PASS.

> LayoutTests/fast/css/attribute-child-selector.html:28
> +        test();

No need to have a test function since you just call it directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.