[Webkit-unassigned] [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59193


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94610|0                           |1
        is obsolete|                            |
  Attachment #94781|                            |review?, commit-queue?
               Flag|                            |




--- Comment #17 from Vsevolod Vlasov <vsevik at chromium.org>  2011-05-25 07:49:59 PST ---
Created an attachment (id=94781)
 --> (https://bugs.webkit.org/attachment.cgi?id=94781&action=review)
Patch with fixes

(In reply to comment #16)
> (From update of attachment 94610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94610&action=review
> 
> > Source/WebCore/inspector/front-end/ResourceView.js:95
> > +    _contentLoaded: function (callback, text)
> 
> Why not make it a local function in requestContent?
Done.

> > Source/WebCore/inspector/front-end/ResourceView.js:-220
> > -        function contentLoaded(text)
> 
> What's the reason for moving this out of the requestContent?
None :) Moved back in.

> > Source/WebCore/inspector/front-end/ResourcesPanel.js:407
> > +        return treeElement.sourceView();
> 
> Can treeElement be undefined?
No, revision treeElement always already exists when showRevisionView is called.

> > Source/WebCore/inspector/front-end/ResourcesPanel.js:1189
> > +    this._resource.addEventListener("errors-warnings-cleared", this._errorsWarningsCleared, this);
> 
> You can listen for ConsoleCleared for consistency, otherwise some console-related events come from Resources while others from the Console directly.
Now listening to both events from resource only to keep logic for resource selection at one place.

> > Source/WebCore/inspector/front-end/ResourcesPanel.js:-1289
> > -        if (this._storagePanel.currentQuery)
> 
> Should this check be preserved?
Done.

> > Source/WebCore/inspector/front-end/ResourcesPanel.js:1344
> > +        if (this._storagePanel.currentQuery)
> 
> Remove this.
Done.

> > Source/WebCore/inspector/front-end/ResourcesPanel.js:1411
> > +        delete oldView;
> 
> This doesn't make sense, please remove.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.