[Webkit-unassigned] [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 10:10:49 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=59193
Yury Semikhatsky <yurys at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94610|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #16 from Yury Semikhatsky <yurys at chromium.org> 2011-05-24 10:10:48 PST ---
(From update of attachment 94610)
View in context: https://bugs.webkit.org/attachment.cgi?id=94610&action=review
> Source/WebCore/inspector/front-end/ResourceView.js:95
> + _contentLoaded: function (callback, text)
Why not make it a local function in requestContent?
> Source/WebCore/inspector/front-end/ResourceView.js:-220
> - function contentLoaded(text)
What's the reason for moving this out of the requestContent?
> Source/WebCore/inspector/front-end/ResourcesPanel.js:407
> + return treeElement.sourceView();
Can treeElement be undefined?
> Source/WebCore/inspector/front-end/ResourcesPanel.js:1189
> + this._resource.addEventListener("errors-warnings-cleared", this._errorsWarningsCleared, this);
You can listen for ConsoleCleared for consistency, otherwise some console-related events come from Resources while others from the Console directly.
> Source/WebCore/inspector/front-end/ResourcesPanel.js:-1289
> - if (this._storagePanel.currentQuery)
Should this check be preserved?
> Source/WebCore/inspector/front-end/ResourcesPanel.js:1344
> + if (this._storagePanel.currentQuery)
Remove this.
> Source/WebCore/inspector/front-end/ResourcesPanel.js:1411
> + delete oldView;
This doesn't make sense, please remove.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list