[Webkit-unassigned] [Bug 57418] [Qt] [Symbian] GraphicsLayer: support plugins on symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57418


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91306|review?                     |review-
               Flag|                            |




--- Comment #19 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-05-24 15:49:06 PST ---
(From update of attachment 91306)
View in context: https://bugs.webkit.org/attachment.cgi?id=91306&action=review

r- to make sure guards are used consistently.

>>>>>> Source/WebCore/plugins/PluginView.h:432
>>>>>> +#if USE(ACCELERATED_COMPOSITING) && (defined(XP_UNIX) || OS(SYMBIAN))
>>>>> 
>>>>> Why the unix here?
>>>> 
>>>> +1
>>> 
>>> Because this patch adds AC plugin layer implementation for symbian to already existing unix implementation. Mac and windows still do not have plugin AC layer implementation for Qt. I just modified existing ifdef (added SYMBIAN).
>>> It's a bit unclear, because I had to break previous #ifdef at line 429 (paintUsingXPixmap is not needed on symbian and other platforms).
>> 
>> Sounds like we might want to come up with a new define then.  Otherwise we're going to have to add defined(WIN) || everywhere when we add win, and then again fo mac, etc.
> 
> After mac and win AC plugin layers are implemented this condition can be removed because all 4 platforms will be supported.

This probably breaks the build when ENABLE(NETSCAPE_PLUGIN_API) is false. A local macro use consistently would help avoid making mistakes like this and would help with readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.