[Webkit-unassigned] [Bug 57418] [Qt] [Symbian] GraphicsLayer: support plugins on symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57418





--- Comment #18 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-05-24 15:44:44 PST ---
> > > > Source/WebCore/plugins/PluginView.h:432
> > > > +#if USE(ACCELERATED_COMPOSITING) && (defined(XP_UNIX) || OS(SYMBIAN))
> > > 
> > > Why the unix here?
> > 
> > Because this patch adds AC plugin layer implementation for symbian to already existing unix implementation. Mac and windows still do not have plugin AC layer implementation for Qt. I just modified existing ifdef (added SYMBIAN).
> > It's a bit unclear, because I had to break previous #ifdef at line 429 (paintUsingXPixmap is not needed on symbian and other platforms).
> 
> Sounds like we might want to come up with a new define then.  

Perhaps a local macro ?

#if PLATFORM(QT) && USE(ACCELERATED_COMPOSITING) && ENABLE(NETSCAPE_PLUGIN_API) && (defined(XP_UNIX) || OS(SYMBIAN))
#define WTF_USE_ACCELERATED_COMPOSITING_PLUGIN_LAYER
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.