[Webkit-unassigned] [Bug 60377] [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60377


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94622|review?                     |review-
               Flag|                            |




--- Comment #25 from Andreas Kling <kling at webkit.org>  2011-05-24 09:19:56 PST ---
(From update of attachment 94622)
View in context: https://bugs.webkit.org/attachment.cgi?id=94622&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2446
> -        if (info.size > 1)
> +        if (info.size > 1 && info.name.endsWith("[0]"))

Is "[0]" the only thing we should be stripping. What about "[1]"?
This looks like a testable change, why is there no new test in this patch?

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:-1448
> -    ASSERT(program);

This should be in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.