[Webkit-unassigned] [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59193


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94054|0                           |1
        is obsolete|                            |
  Attachment #94054|review?, commit-queue?      |
               Flag|                            |
  Attachment #94609|                            |review?, commit-queue?
               Flag|                            |




--- Comment #14 from Vsevolod Vlasov <vsevik at chromium.org>  2011-05-24 07:35:13 PST ---
Created an attachment (id=94609)
 --> (https://bugs.webkit.org/attachment.cgi?id=94609&action=review)
Patch with fixes after review

(In reply to comment #13)
> (From update of attachment 94054 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94054&action=review
> 
> > Source/WebCore/inspector/front-end/ResourceView.js:46
> > +WebInspector.ResourceView.isSourceViewableForResource = function(resource)
> 
> Maybe hasTextContent?
Done.

> > Source/WebCore/inspector/front-end/ResourceView.js:73
> > +    WebInspector.SourceFrameDelegate.call(this);
> 
> SourceFrameDelegate is a scripts panel specific delegate used to invert SourceFrame -> ScriptsPanel dependency. It's strange that you derive ResourceSourceFrameDelegate from it. Could you implement TextViewerDelegate interface instead?
As discussed, I have overridden these methods in SourceFrame descendants.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.