[Webkit-unassigned] [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59193





--- Comment #13 from Pavel Podivilov <podivilov at chromium.org>  2011-05-23 00:51:43 PST ---
(From update of attachment 94054)
View in context: https://bugs.webkit.org/attachment.cgi?id=94054&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:46
> +WebInspector.ResourceView.isSourceViewableForResource = function(resource)

Maybe hasTextContent?

> Source/WebCore/inspector/front-end/ResourceView.js:73
> +    WebInspector.SourceFrameDelegate.call(this);

SourceFrameDelegate is a scripts panel specific delegate used to invert SourceFrame -> ScriptsPanel dependency. It's strange that you derive ResourceSourceFrameDelegate from it. Could you implement TextViewerDelegate interface instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.