[Webkit-unassigned] [Bug 61170] Zombies should "live" forever

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 20 10:03:41 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61170





--- Comment #3 from Zoltan Herczeg <zherczeg at webkit.org>  2011-05-20 10:03:41 PST ---
> > Source/JavaScriptCore/JavaScriptCore.pro:-67
> > -    assembler/MacroAssemblerSH4.h \
> >      assembler/MacroAssemblerSH4.cpp \
> > -    assembler/SH4Assembler.h \
> 
> Why remove these?  Or at least why remove them in this patch?

True, it is unrelated. That list should contain only .cpp files. It is just a typo.

> > Source/JavaScriptCore/runtime/WriteBarrier.h:132
> > -        ASSERT(!m_cell || !isZombie(m_cell));
> > +        ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell));
> 
> What are you testing here?

CodeBlock.h : setSeen():
cachedPrototypeStructure.setWithoutWriteBarrier((Structure*)1);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list